[GIT PULL, RESEND] Reset controller fixes and updates

Arnd Bergmann arnd at arndb.de
Wed Mar 26 20:34:51 EDT 2014


On Wednesday 19 March 2014, Philipp Zabel wrote:
> The following changes since commit 38dbfb59d1175ef458d006556061adeaa8751b72:
> 
>   Linus 3.14-rc1 (2014-02-02 16:42:13 -0800)
> 
> are available in the git repository at:
> 
>   git://git.pengutronix.de/git/pza/linux.git reset/for_v3.15
> 
> for you to fetch changes up to b424080a9e086e683ad5fdc624a7cf3c024e0c0f:
> 
>   reset: Add optional resets and stubs (2014-03-09 19:53:45 +0100)
> 

I've merged them into next/drivers now, sorry for the delay.

Just one question that came in another thread, about the interface when
the reset controllers are disabled: You return ERR_PTR(-ENOSYS)
from reset_control_get_optional() here, and WARN_ON() any functions
called later. Are you sure this is the best interface? We have other
subsystems that just return a NULL pointer in this case so it doesn't
trigger IS_ERR(), and then you can pass the NULL pointer into the
other functions without causing an error message.

	Arnd



More information about the linux-arm-kernel mailing list