[PATCH v3][ 5/9] ARM: dts: imx25.dtsi: Fix USB support.

[Fabio Estevam]

Hi Denis,

On Wed, Mar 12, 2014 at 7:01 AM, Denis Carikli <denis at eukrea.com> wrote:
> From: Fabio Estevam <fabio.estevam at freescale.com>
>
> This patch was adapted from the thread named
> "USB Host support for mx25" on linux-usb at vger.kernel.org
>

As you add me in the From field, you also need to add:

Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com> above your
Signed-off-by line.

> Signed-off-by: Denis Carikli <denis at eukrea.com>
> +
> +       usbphy {
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               compatible = "simple-bus";

I made this comment earlier: why do we place usbphy0/1 under simple-bus?

This is not documented in the the bindings.

> +
> +               usbphy0: usbphy at 0 {
> +                       reg = <0>;
> +                       compatible = "usb-nop-xceiv";
> +               };
> +
> +               usbphy1: usbphy at 1 {
> +                       reg = <1>;
> +                       compatible = "usb-nop-xceiv";
> +               };
> +       };

Regards,

Fabio Estevam