Re: [PATCH] ahci_imx: Put #ifdef CONFIG_PM_SLEEP around suspend / resume functions

[Alexander Shiyan]

Среда,  5 марта 2014, 20:23 +01:00 от Marek Vasut <marex at denx.de>:
> On Wednesday, March 05, 2014 at 08:17:49 PM, Hans de Goede wrote:
> > This fixes the following warnings when CONFIG_PM_SLEEP is not set:
> > 
> > drivers/ata/ahci_imx.c:284:12: warning: ‘imx_ahci_suspend’ defined but not
> > used [-Wunused-function] drivers/ata/ahci_imx.c:299:12: warning:
> > ‘imx_ahci_resume’ defined but not used [-Wunused-function]
> > 
> > Reported-by: Bartlomiej Zolnierkiewicz <b.zolnierkie at samsung.com>
> > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie at samsung.com>
> > Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> 
> Obviously makes sense.
> 
> Acked-by: Marek Vasut <marex at denx.de>

But a better way is to use the "__maybe_unused" attribute for such cases.

---