[PATCH] thermal: Add missing cpumask_clear

Jonghwan Choi jhbird.choi at samsung.com
Fri Jul 4 17:40:38 PDT 2014


On Fri, Jul 5, 2014 at 9:34 AM, Tomasz Figa <tomasz.figa at gmail.com> wrote:
> > Console message-> 4.861157] [c6] --ID [ 1] = 0,4-5,7 (4,5,7 cpu bit
> > was set.)
> >
> > And when I tried to register two cooling devices with cpumask_set_cpu(0, &mask_val) and
> cpumask_set_cpu(4, &mask_val).
> >
> > I found that cpu 0 bit is also set in latter cpumask. (I hope latter
> > cpumask has a cpu 4 bit.)
> >
> > So I think that cpumask_clear should be inserted.
> 
> I believe Sachin's concern was related to your patch description. A good description should say what
> the patch changes and what is the rationale behind this change. Also for fixes it is a good practice
> to specify observed issues in patch description as well.
> 
> Best regards,

-> You are right.

Thanks for your kind advice.


Best regards.




More information about the linux-arm-kernel mailing list