[PATCH] mmc: dw_mmc: fix dw_mci_get_cd

Chris Ball chris at printf.net
Fri Jan 17 09:25:30 EST 2014


Hi,

On Fri, Jan 17 2014, Seungwon Jeon wrote:
> On Fri, January 17, 2014, Kevin Hilman wrote:
>> Zhangfei Gao <zhangfei.gao at linaro.org> writes:
>> 
>> > Introduced from commit bf626e5550f24aec24975a0e85ad8e572ca76a6b
>> > CDETECT is ignored since negated return value of mmc_gpio_get_cd(mmc)
>> > can not be checked by IS_ERR_VALUE.
>> > Add spin_lock_bh(&host->lock) for atomic accessing DW_MMC_CARD_PRESENT,
>> > otherwise sd detect may occasionally fail.
>> >
>> > Signed-off-by: Zhangfei Gao <zhangfei.gao at linaro.org>
>> > Reported-by: Kevin Hilman <khilman at linaro.org>
>> > Reviewed-by: Sachin Kamat <sachin.kamat at linaro.org>
>> > Tested-by: Sachin Kamat <sachin.kamat at linaro.org>
>> 
>> I didn't look at the patch in detail, but can at least confirm that
>> Arndale boots again in -next with this patch applied.
>> 
>> Tested-by: Kevin Hilman <khilman at linaro.org>
>
> Acked-by: Seungwon Jeon <tgih.jun at samsung.com>

Thanks, pushed to mmc-next for 3.14.

- Chris.
-- 
Chris Ball   <chris at printf.net>   <http://printf.net/>



More information about the linux-arm-kernel mailing list