[PATCH REPOST] ARM: Fix regression in IXP4xx network drivers DMA masks.

Russell King - ARM Linux linux at arm.linux.org.uk
Sat Jan 11 11:13:42 EST 2014


On Mon, Jan 06, 2014 at 08:33:15PM +0100, Krzysztof Hałasa wrote:
> Russell et al.,
> 
> anything wrong with this fix?

Well, I don't understand why moving this code around fixes a problem.
After all, if PCI is enabled, then presumably common-pci.c will always
be built and run - it has to be for the PCI bus to be probed.

Oh, are you trying to use the platform notify callback to set the
DMA mask on statically defined platform devices?  No, don't do that,
initialise it in the declarations instead.

-- 
FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up.  Estimation
in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad.
Estimate before purchase was "up to 13.2Mbit".



More information about the linux-arm-kernel mailing list