[PATCH] dma: of: Move the functions under CONFIG_OF_DMA instead of CONFIG_OF

Arnd Bergmann arnd at arndb.de
Fri Feb 28 04:23:06 EST 2014


On Thursday 27 February 2014 19:27:03 Santosh Shilimkar wrote:
> 
> The of-dma.c is compiled out with !CONFIG_DMA_OF but the functions in
> the header are kept under CONFIG_OF. Move them under CONFIG_OF_DMA
> to avoid build errors with CONFIG_OFF && !CONFIG_DMA_OF
> 
> Cc: Grant Likely <grant.likely at linaro.org>
> Cc: Rob Herring <robh+dt at kernel.org>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar at ti.com>

Sorry, but what is the problem you are seeing with this?

CONFIG_DMA_OF is defined as 'OF && DMAENGINE', and this code
should only be called from drivers that depend on DMAENGINE.

I'm not saying your patch is wrong, but you shouldn't need it
unless you do something very odd.

	Arnd



More information about the linux-arm-kernel mailing list