[RFC PATCH] arm64: add support for AES in CCM mode using Crypto Extensions

Herbert Xu herbert at gondor.apana.org.au
Tue Feb 25 02:16:26 EST 2014


On Tue, Feb 25, 2014 at 08:12:36AM +0100, Ard Biesheuvel wrote:
>
> Do you have any comments specifically about using an inner blkcipher
> instance to implement the aead?

Indeed, the inner block cipher looks superfluous since it's only
used once by ccm and there is no nesting similar to aesni-intel.

Inner algorithms are only needed if you want to nest it, e.g.,
through fpu().  Otherwise I don't see any difference vs. calling
the underlying functions directly, especially since you seem to
be calling them directly anyway.

Cheers,
-- 
Email: Herbert Xu <herbert at gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



More information about the linux-arm-kernel mailing list