[PATCH] input: sirfsoc-onkey - report onkey untouch event by detecting pin status

Dmitry Torokhov dmitry.torokhov at gmail.com
Wed Feb 12 18:11:31 EST 2014


Hi Barry,

On Mon, Feb 10, 2014 at 06:07:39PM +0800, Barry Song wrote:
>  
>  static int sirfsoc_pwrc_remove(struct platform_device *pdev)
>  {
> +	struct sirfsoc_pwrc_drvdata *pwrcdrv = dev_get_drvdata(&pdev->dev);
> +
>  	device_init_wakeup(&pdev->dev, 0);
>  
> +	cancel_delayed_work_sync(&pwrcdrv->work);
> +

This is racy: interrupt is freed later and can schedule work again.

Thanks.

-- 
Dmitry



More information about the linux-arm-kernel mailing list