[PATCH 2/3] mfd: axp20x: Add dtsi for axp20x

Carlo Caione carlo at caione.org
Mon Feb 10 15:10:34 EST 2014


On Mon, Feb 10, 2014 at 9:08 PM, Lee Jones <lee.jones at linaro.org> wrote:
> On Sat, 08 Feb 2014, Carlo Caione wrote:
>
>> This patch adds a new dtsi for supporting axp20x.
>>
>> Signed-off-by: Carlo Caione <carlo at caione.org>
>> ---
>>  arch/arm/boot/dts/axp20x.dtsi | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>  create mode 100644 arch/arm/boot/dts/axp20x.dtsi
>>
>> diff --git a/arch/arm/boot/dts/axp20x.dtsi b/arch/arm/boot/dts/axp20x.dtsi
>> new file mode 100644
>> index 0000000..98d4c7c
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/axp20x.dtsi
>> @@ -0,0 +1,9 @@
>> +/*
>> +* Integrated Power Management Chip AXP209
>> +*/
>> +
>> +&axp {
>> +     compatible = "x-powers,axp20x";
>> +     interrupt-controller;
>> +     #interrupt-cells = <1>;
>> +};
>
> I's suggest not doing it this way. Having a .dtsi file for every
> device is not the way Device Tree has been designed. This snippet
> should be copied directly into device's .dts(i) files.

Well, ok then :) I'll fix it in v2.

Thanks,

-- 
Carlo Caione



More information about the linux-arm-kernel mailing list