[RFC PATCH v2] drivers: pci: move PCI domain assignment to generic PCI code

Bjorn Helgaas bhelgaas at google.com
Sat Dec 27 17:22:49 PST 2014


On Sat, Dec 27, 2014 at 3:36 AM, Lorenzo Pieralisi
<lorenzo.pieralisi at arm.com> wrote:
> Hi Bjorn,
>
> On Thu, Nov 20, 2014 at 10:54:49PM +0000, Bjorn Helgaas wrote:
>> On Mon, Nov 10, 2014 at 04:41:46PM +0000, Lorenzo Pieralisi wrote:
>> > The current logic used for PCI domain assignment in arm64
>> > pci_bus_assign_domain_nr() is flawed in that, depending on the host
>> > controllers configuration for a platform and the respective initialization
>> > sequence, core code may end up allocating PCI domain numbers from both DT and
>> > the core code generic domain counter, which would result in PCI domain
>> > allocation aliases/errors.
>> >
>> > This patch fixes the logic behind the PCI domain number assignment and
>> > moves the resulting code to generic PCI core code so that the same domain
>> > allocation logic is used on all platforms selecting
>> >
>> > CONFIG_PCI_DOMAINS_GENERIC
>> >
>> > instead of resorting to an arch specific implementation that might end up
>> > duplicating the PCI domain assignment logic wrongly.
>> >
>> > Cc: Arnd Bergmann <arnd at arndb.de>
>> > Cc: Liviu Dudau <liviu.dudau at arm.com>
>> > Cc: Bjorn Helgaas <bhelgaas at google.com>
>> > Cc: Rob Herring <robh+dt at kernel.org>
>> > Cc: Catalin Marinas <catalin.marinas at arm.com>
>> > Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi at arm.com>
>>
>> Applied with Liviu and Arnd's acks to pci/domain for v3.19, thanks.
>>
>> It doesn't matter whether I'm in the to: or cc: list.  The important thing
>> is that it appears on the linux-pci list, because I use patchwork as my
>> to-do list, and patchwork only vacuums up stuff from linux-pci.
>
> This patch has not been merged last cycle and it is a prerequisite for
> the ARM pcibios domain code removal patchset you merged in your pci/domain
> branch. Please consider pulling it there so that the ARM pcibios domain
> removal patchset can be based correctly on top of this patch, at the
> moment it can't compile (see kbuild test report).

Huh, I can't remember why I didn't merge that for v3.19.  Maybe I just
missed it by mistake.

Anyway, I picked that patch into pci/domain for another try.

Bjorn



More information about the linux-arm-kernel mailing list