[PATCH 3/3] ARM: edma: Split up header file to platform_data and API file

Arnd Bergmann arnd at arndb.de
Mon Dec 8 05:16:59 PST 2014


On Monday 08 December 2014 18:19:17 Vinod Koul wrote:
> On Thu, Nov 27, 2014 at 12:41:31PM +0200, Peter Ujfalusi wrote:
> > include/linux/platform_data/ is not a correct place to keep the API
> > definitions for edma, it is meant to be only for the pdata for the device.
> > Clean up this by moving the API to include/linux/edma.h
> > 
> > Signed-off-by: Peter Ujfalusi <peter.ujfalusi at ti.com>
> > ---
> >  arch/arm/common/edma.c                     |   3 +-
> >  arch/arm/mach-davinci/devices.c            |   1 +
> >  arch/arm/mach-davinci/include/mach/da8xx.h |   1 +
> >  drivers/dma/edma.c                         |   2 +-
> >  include/linux/edma.h                       | 153 +++++++++++++++++++++++++++++
> >  include/linux/platform_data/edma.h         | 148 ++--------------------------
> >  sound/soc/davinci/davinci-pcm.h            |   1 +
> >  7 files changed, 165 insertions(+), 144 deletions(-)
> >  create mode 100644 include/linux/edma.h
> I was hoping that this will have delete for platform_data/edma.h, do we
> still need that and why shouldn't we get rid of this 

I think the platform_data/edma.h file is needed for as long as we have
mach-davinci systems that are not converted to boot using DT. At the current
pace of development in that area, I would expect that to take a few more
years at least: da850 support is slowly proceeding (since 2012), da830 should
be fairly straightforward to add once da850 is done, but I haven't seen
anybody start working on the dm* socs for DT.

	Arnd



More information about the linux-arm-kernel mailing list