[PATCH 1/2] doc: dt/bindings: input: introduce TI DRV2667 haptic driver description

Sergei Shtylyov sergei.shtylyov at cogentembedded.com
Thu Aug 21 12:04:15 PDT 2014


Hello.

On 08/21/2014 10:19 PM, Dan Murphy wrote:

> DRV2667 is a haptic/vibrator driver for Linear Resonant Actuators.
> Adding dt binding for this part

> Signed-off-by: Dan Murphy <dmurphy at ti.com>
> ---
>   .../devicetree/bindings/input/ti,drv2667.txt       |   18 ++++++++++++++++++
>   1 file changed, 18 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/input/ti,drv2667.txt

> diff --git a/Documentation/devicetree/bindings/input/ti,drv2667.txt b/Documentation/devicetree/bindings/input/ti,drv2667.txt
> new file mode 100644
> index 0000000..525216d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/ti,drv2667.txt
> @@ -0,0 +1,18 @@
> +Texas Instruments - drv2667 Haptics driver
> +
> +The drv2667 uses serial control bus communicates through I2C protocols
> +
> +Required properties:
> +	- compatible - "ti,drv2667" - DRV2667
> +	- reg -  I2C slave address
> +	- vbat-supply - Required supply regulator
> +
> +Example:
> +
> +drv2667: drv2667 at 59 {

    The ePAPR standard [1] has something to say on this matter:

"The name of a node should be somewhat generic, reflecting the function of the 
device and not its precise programming model."

> +		compatible = "ti,drv2667";

    Indented too much to the right.

> +		reg = <0x59>;

    Still no "vbat-supply"... :-/

> +};
[...]

WBR, Sergei




More information about the linux-arm-kernel mailing list