[PATCH v3 5/7] arm: kgdb: Handle read-only text / modules

Stephen Boyd sboyd at codeaurora.org
Tue Aug 12 12:38:12 PDT 2014


On 08/12/14 11:24, Kees Cook wrote:
> @@ -244,6 +248,32 @@ void kgdb_arch_exit(void)
>  	unregister_die_notifier(&kgdb_notifier);
>  }
>  
> +int kgdb_arch_set_breakpoint(struct kgdb_bkpt *bpt)
> +{
> +	int err;
> +
> +	/* patch_text() only supports int-sized breakpoints */
> +	if (sizeof(int) != BREAK_INSTR_SIZE)
> +		return -EINVAL;

Could this be a BUILD_BUG_ON too?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation




More information about the linux-arm-kernel mailing list