[RFC 4/5] ARM: dts: add pinctrl support to Exynos5410

Tomasz Figa tomasz.figa at gmail.com
Fri Aug 8 06:29:30 PDT 2014


Hi,

Please see my comment inline.

On 28.07.2014 14:18, Andreas Färber wrote:
> From: Hakjoo Kim <ruppi.kim at hardkernel.com>
> 
> Add the required pin configuration support to Exynos5410 using pinctrl
> interface.

[snip]

> +	pinctrl_0: pinctrl at 13400000 {
> +		compatible = "samsung,exynos5410-pinctrl";
> +		reg = <0x13400000 0x1000>;
> +		interrupts = <0 45 0>;

I believe you are missing the wake-up IRQ controller node here, which is
needed to handle the interrupts of EINTW (gpxN) banks.

Best regards,
Tomasz



More information about the linux-arm-kernel mailing list