[PATCH 14/29] ARM: orion: switch to a per-platform handle_irq() function

Sebastian Hesselbarth sebastian.hesselbarth at gmail.com
Sat Apr 19 09:16:32 PDT 2014


On 04/19/2014 02:04 PM, Thomas Petazzoni wrote:
> Dear Sebastian Hesselbarth,
>>> Also, this approach goes towards the goal of reducing plat-orion/ code.
>>> Having the code closer to each SoC is going to make it easier to
>>> progressively get rid of it I believe.
>>
>> Ok, I agree. But IIRC the multi-irq handler is only needed, if you
>> compile both DT and non-DT in one kernel, right?
> 
> Correct.
> 
>> Dove DT just left mach-dove, so there is no way you can compile both.
>> For the sake of simplicity, I'd even agree on adding it now and
>> remove it later again. But at least for Dove, the move is bogus.
> 
> I think there's a lot of possible following clean up to be made. But we
> have to define some limits to the current patch series, otherwise it's
> going to grow to a 50+ patches monster that will be very hard to merge.
> I clearly agree some of things are not in their final ideal state, but
> I believe, overall, this patch series for Orion5x is pushing things in
> the right direction, no?

Agreed, the patch set is a great step for Orion5x. Let's do proper
cleanup afterwards. Thanks for working on it!

Sebastian




More information about the linux-arm-kernel mailing list