[RFC PATCH 08/15] ata: ahci_platform: Manage SATA PHY

Sergei Shtylyov sergei.shtylyov at cogentembedded.com
Mon Sep 23 10:10:30 EDT 2013


Hello.

On 09/23/2013 01:48 AM, Tejun Heo wrote:

>>> @@ -37,6 +37,7 @@

>>>   #include <linux/clk.h>
>>>   #include <linux/libata.h>
>>> +#include <linux/phy/phy.h>

>> struct phy;

>> should suffice.

> Unless it's actually likely to cause inclusion loop, I think it's
> better to include the header than adding explicit declarations.

    Apparently, tastes differ here. E.g. Greg KH would have also told Roger to 
use forward declaration in such case. :-)

> Thanks.

WBR, Sergei




More information about the linux-arm-kernel mailing list