[PATCHv6 01/45] CLK: TI: Add DPLL clock support

Tony Lindgren tony at atomide.com
Tue Sep 17 12:09:36 EDT 2013


* Tero Kristo <t-kristo at ti.com> [130829 06:24]:
> The OMAP clock driver now supports DPLL clock type. This patch also
> adds support for DT DPLL nodes.
...

> +- reg-names : array of the register names for controlling the device, sorted
> +  in the same order as the reg property.
> +	"control" - contains the control register base address
> +        "idlest" - contains the idle status register base address
> +        "autoidle" - contains the autoidle register base address
> +        "mult-div1" - contains the multiplier / divider register base address

FYI, looks like there's some tab vs spaces issue with the
formatting above.

> +Examples:
> +	dpll_core_ck: dpll_core_ck at 44e00490 {
> +		#clock-cells = <0>;
> +		compatible = "ti,omap4-dpll-core-clock";
> +		clocks = <&sys_clkin_ck>, <&sys_clkin_ck>;
> +		reg = <0x44e00490 0x4>, <0x44e0045c 0x4>, <0x0 0x4>,
> +				<0x44e00468 0x4>;
> +		reg-names = "control", "idlest", "autoidle", "mult-div1";
> +	};
> +
> +	dpll2_ck: dpll2_ck at 48004004 {
> +		#clock-cells = <0>;
> +		compatible = "ti,omap3-dpll-clock";
> +		clocks = <&sys_ck>, <&dpll2_fck>;
> +		ti,modes = <0xa2>;
> +		reg = <0x48004004 0x4>, <0x48004024 0x4>, <0x48004034 0x4>,
> +			<0x48004040 0x4>;
> +		reg-names = "control", "idlest", "autoidle", "mult-div1";
> +		ti,clkdm-name = "dpll2_clkdm";
> +	};

Do you need the reg-names at all? You may be able to do that
automatically in the driver based on the compatible flags if
you only have few different types.

Regards,

Tony



More information about the linux-arm-kernel mailing list