[PATCHv2 1/3] Input: twl4030-keypad - add device tree support

Tony Lindgren tony at atomide.com
Sun Oct 27 08:23:48 EDT 2013


* Pavel Machek <pavel at ucw.cz> [131027 04:48]:
> 
> > > > +#if IS_ENABLED(CONFIG_OF)
> > > I'm probably missing something here, but why not #ifdef CONFIG_OF?
> > 
> > I have been told for other drivers, that IS_ENABLED() is
> > the prefered way to check for configuration these days.
> 
> CONFIG_OF can not be module, using IS_ENABLED() on it is just wrong.

Good point. Looks like there's IS_BUILTIN that's for boolean options.

Regards,

Tony



More information about the linux-arm-kernel mailing list