[PATCH 4/8] input: Remove OOM message after input_allocate_device

Dmitry Torokhov dmitry.torokhov at gmail.com
Thu Oct 24 14:37:08 EDT 2013


Hi Joe,

On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote:
> Emitting an OOM message isn't necessary after input_allocate_device
> as there's a generic OOM and a dump_stack already done.

No, please don't. The kzalloc may get changed in the future to not dump
stack (that was added originally because not everyone was handling OOM
properly, right?), input core might get changed to use something else
than kzalloc, etc, etc.

The majority of errors use dev_err so we also get idea what device
failed (if there are several), and more.

Thanks.

-- 
Dmitry



More information about the linux-arm-kernel mailing list