RE: 回复：Re: [v1] ahci: imx: setup power saving methods

[Zhu Richard-R65037]

Hi Tejun:
I'm back from holiday, Thanks for your review and suggestions.
The kernel build option would be replaced by the usage of the module parameters.

Best Regards
Richard Zhu


-----Original Message-----
From: Tejun Heo [mailto:htejun at gmail.com] On Behalf Of Tejun Heo
Sent: Sunday, September 29, 2013 8:51 PM
To: Shawn Guo
Cc: Zhu Richard-R65037; Richard Zhu; linux-arm-kernel at lists.infradead.org; jgarzik at pobox.com; linux-ide at vger.kernel.org
Subject: Re: 回复：Re: [v1] ahci: imx: setup power saving methods

On Sun, Sep 29, 2013 at 03:48:18PM +0800, Shawn Guo wrote:
> On Sun, Sep 29, 2013 at 07:40:57AM +0000, Zhu Richard-R65037 wrote:
> > Hi Shawn:
> > Thanks.
> > The hot-plug can’t be supported, if we support this method unconditionally.
> 
> Ah, okay.  Then you should make this clear in the help text of the 
> Kconfig option.

Yeah but it's still weird to require kernel build to flip this feature, isn't it?  Shouldn't it be a module param or something?

Thanks.

--
tejun