[PATCH] ARM: OMAP2: gpmc-onenand: fix sync mode setup with DT
Aaro Koskinen
aaro.koskinen at iki.fi
Tue Oct 1 17:33:18 EDT 2013
Hi,
Any comments about the below patch? If my analysis is correct, this issue
needs to be fixed before any boards that set ONENAND_SYNC_READWRITE can
be converted to DT. So the fix should be applied preferably during the
current rc-cycle.
A.
On Fri, Sep 20, 2013 at 11:01:06PM +0300, Aaro Koskinen wrote:
> With DT-based boot, the GPMC OneNAND sync mode setup does not work
> correctly. During the async mode setup, sync flags gets incorrectly
> set in the onenand_async data and the system crashes during the async
> setup. Also, the sync mode never gets set in gpmc_onenand_data->flags, so
> even without the crash, the actual sync mode setup would never be called.
>
> The patch fixes this by adjusting the gpmc_onenand_data->flags when the
> data is read from the DT. Also while doing this we force the onenand_async
> to be always async.
>
> The patch enables to use the following DTS chunk (that should correspond
> the arch/arm/mach-omap2/board-rm680.c board file setup) with Nokia N950,
> which currently crashes with 3.12-rc1. The crash output can be also
> found below.
>
> &gpmc {
> ranges = <0 0 0x04000000 0x20000000>;
>
> onenand at 0,0 {
> #address-cells = <1>;
> #size-cells = <1>;
> reg = <0 0 0x20000000>;
>
> gpmc,sync-read;
> gpmc,sync-write;
> gpmc,burst-length = <16>;
> gpmc,burst-read;
> gpmc,burst-wrap;
> gpmc,burst-write;
> gpmc,device-width = <2>;
> gpmc,mux-add-data = <2>;
> gpmc,cs-on-ns = <0>;
> gpmc,cs-rd-off-ns = <87>;
> gpmc,cs-wr-off-ns = <87>;
> gpmc,adv-on-ns = <0>;
> gpmc,adv-rd-off-ns = <10>;
> gpmc,adv-wr-off-ns = <10>;
> gpmc,oe-on-ns = <15>;
> gpmc,oe-off-ns = <87>;
> gpmc,we-on-ns = <0>;
> gpmc,we-off-ns = <87>;
> gpmc,rd-cycle-ns = <112>;
> gpmc,wr-cycle-ns = <112>;
> gpmc,access-ns = <81>;
> gpmc,page-burst-access-ns = <15>;
> gpmc,bus-turnaround-ns = <0>;
> gpmc,cycle2cycle-delay-ns = <0>;
> gpmc,wait-monitoring-ns = <0>;
> gpmc,clk-activation-ns = <5>;
> gpmc,wr-data-mux-bus-ns = <30>;
> gpmc,wr-access-ns = <81>;
> gpmc,sync-clk-ps = <15000>;
> };
> };
>
> [ 1.467559] GPMC CS0: cs_on : 0 ticks, 0 ns (was 0 ticks) 0 ns
> [ 1.474822] GPMC CS0: cs_rd_off : 1 ticks, 5 ns (was 24 ticks) 5 ns
> [ 1.482116] GPMC CS0: cs_wr_off : 14 ticks, 71 ns (was 24 ticks) 71 ns
> [ 1.489349] GPMC CS0: adv_on : 0 ticks, 0 ns (was 0 ticks) 0 ns
> [ 1.496582] GPMC CS0: adv_rd_off: 3 ticks, 15 ns (was 3 ticks) 15 ns
> [ 1.503845] GPMC CS0: adv_wr_off: 3 ticks, 15 ns (was 3 ticks) 15 ns
> [ 1.511077] GPMC CS0: oe_on : 3 ticks, 15 ns (was 4 ticks) 15 ns
> [ 1.518310] GPMC CS0: oe_off : 1 ticks, 5 ns (was 24 ticks) 5 ns
> [ 1.525543] GPMC CS0: we_on : 0 ticks, 0 ns (was 0 ticks) 0 ns
> [ 1.532806] GPMC CS0: we_off : 8 ticks, 40 ns (was 24 ticks) 40 ns
> [ 1.540039] GPMC CS0: rd_cycle : 4 ticks, 20 ns (was 29 ticks) 20 ns
> [ 1.547302] GPMC CS0: wr_cycle : 4 ticks, 20 ns (was 29 ticks) 20 ns
> [ 1.554504] GPMC CS0: access : 0 ticks, 0 ns (was 23 ticks) 0 ns
> [ 1.561767] GPMC CS0: page_burst_access: 0 ticks, 0 ns (was 3 ticks) 0 ns
> [ 1.569641] GPMC CS0: bus_turnaround: 0 ticks, 0 ns (was 0 ticks) 0 ns
> [ 1.577270] GPMC CS0: cycle2cycle_delay: 0 ticks, 0 ns (was 0 ticks) 0 ns
> [ 1.585144] GPMC CS0: wait_monitoring: 0 ticks, 0 ns (was 0 ticks) 0 ns
> [ 1.592834] GPMC CS0: clk_activation: 0 ticks, 0 ns (was 0 ticks) 0 ns
> [ 1.600463] GPMC CS0: wr_data_mux_bus: 5 ticks, 25 ns (was 8 ticks) 25 ns
> [ 1.608154] GPMC CS0: wr_access : 0 ticks, 0 ns (was 23 ticks) 0 ns
> [ 1.615386] GPMC CS0 CLK period is 5 ns (div 1)
> [ 1.625122] Unhandled fault: external abort on non-linefetch (0x1008) at 0xf009e442
> [ 1.633178] Internal error: : 1008 [#1] ARM
> [ 1.637573] Modules linked in:
> [ 1.640777] CPU: 0 PID: 1 Comm: swapper Not tainted 3.12.0-rc1-n9xx-los.git-5318619-00006-g4baa700-dirty #26
> [ 1.651123] task: ef04c000 ti: ef050000 task.ti: ef050000
> [ 1.656799] PC is at gpmc_onenand_setup+0x98/0x1e0
> [ 1.661865] LR is at gpmc_cs_set_timings+0x494/0x5a4
> [ 1.667083] pc : [<c002e040>] lr : [<c001f384>] psr: 60000113
> [ 1.667083] sp : ef051d10 ip : ef051ce0 fp : ef051d94
> [ 1.679138] r10: c0caaf60 r9 : ef050000 r8 : ef18b32c
> [ 1.684631] r7 : f0080000 r6 : c0caaf60 r5 : 00000000 r4 : f009e400
> [ 1.691497] r3 : f009e442 r2 : 80050000 r1 : 00000014 r0 : 00000000
> [ 1.698333] Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment kernel
> [ 1.706024] Control: 10c5387d Table: af290019 DAC: 00000015
> [ 1.712066] Process swapper (pid: 1, stack limit = 0xef050240)
> [ 1.718200] Stack: (0xef051d10 to 0xef052000)
> [ 1.722778] 1d00: 00004000 00001402 00000000 00000005
> [ 1.731384] 1d20: 00000047 00000000 0000000f 0000000f 00000000 00000028 0000000f 00000005
> [ 1.739990] 1d40: 00000000 00000000 00000014 00000014 00000000 00000000 00000000 00000000
> [ 1.748596] 1d60: 00000000 00000019 00000000 00000000 ef18b000 ef099c50 c0c8cb30 00000000
> [ 1.757171] 1d80: c0488074 c048f868 ef051dcc ef051d98 c024447c c002dfb4 00000000 c048f868
> [ 1.765777] 1da0: 00000000 00000000 c010e4a4 c0dbbb7c c0c8cb40 00000000 c0ca2500 c0488074
> [ 1.774383] 1dc0: ef051ddc ef051dd0 c01fd508 c0244370 ef051dfc ef051de0 c01fc204 c01fd4f4
> [ 1.782989] 1de0: c0c8cb40 c0ca2500 c0c8cb74 00000000 ef051e1c ef051e00 c01fc3b0 c01fc104
> [ 1.791595] 1e00: ef0983bc 00000000 c0ca2500 c01fc31c ef051e44 ef051e20 c01fa794 c01fc328
> [ 1.800201] 1e20: ef03634c ef0983b0 ef27d534 c0ca2500 ef27d500 c0c9a2f8 ef051e54 ef051e48
> [ 1.808807] 1e40: c01fbcfc c01fa744 ef051e84 ef051e58 c01fb838 c01fbce4 c0411df8 c0caa040
> [ 1.817413] 1e60: ef051e84 c0ca2500 00000006 c0caa040 00000066 c0488074 ef051e9c ef051e88
> [ 1.825988] 1e80: c01fca30 c01fb768 c04975b8 00000006 ef051eac ef051ea0 c01fd728 c01fc9bc
> [ 1.834594] 1ea0: ef051ebc ef051eb0 c048808c c01fd6e4 ef051f4c ef051ec0 c0008888 c0488080
> [ 1.843200] 1ec0: 0000006f c046bae8 00000000 00000000 ef051efc ef051ee0 ef051f04 ef051ee8
> [ 1.851806] 1ee0: c046d400 c0181218 c046d410 c18da8d5 c036a8e4 00000066 ef051f4c ef051f08
> [ 1.860412] 1f00: c004b9a8 c046d41c c048f840 00000006 00000006 c046b488 00000000 c043ec08
> [ 1.869018] 1f20: ef051f4c c04975b8 00000006 c0caa040 00000066 c046d410 c048f85c c048f868
> [ 1.877593] 1f40: ef051f94 ef051f50 c046db8c c00087a0 00000006 00000006 c046d410 ffffffff
> [ 1.886199] 1f60: ffffffff ffffffff ffffffff 00000000 c0348fd0 00000000 00000000 00000000
> [ 1.894805] 1f80: 00000000 00000000 ef051fac ef051f98 c0348fe0 c046daa8 00000000 00000000
> [ 1.903411] 1fa0: 00000000 ef051fb0 c000e7f8 c0348fdc 00000000 00000000 00000000 00000000
> [ 1.912017] 1fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
> [ 1.920623] 1fe0: 00000000 00000000 00000000 00000000 00000013 00000000 ffffffff ffffffff
> [ 1.929199] Backtrace:
> [ 1.931793] [<c002dfa8>] (gpmc_onenand_setup+0x0/0x1e0) from [<c024447c>] (omap2_onenand_probe+0x118/0x49c)
> [ 1.942047] [<c0244364>] (omap2_onenand_probe+0x0/0x49c) from [<c01fd508>] (platform_drv_probe+0x20/0x24)
> [ 1.952117] r8:c0488074 r7:c0ca2500 r6:00000000 r5:c0c8cb40 r4:c0dbbb7c
> [ 1.959197] [<c01fd4e8>] (platform_drv_probe+0x0/0x24) from [<c01fc204>] (driver_probe_device+0x10c/0x224)
> [ 1.969360] [<c01fc0f8>] (driver_probe_device+0x0/0x224) from [<c01fc3b0>] (__driver_attach+0x94/0x98)
> [ 1.979125] r7:00000000 r6:c0c8cb74 r5:c0ca2500 r4:c0c8cb40
> [ 1.985107] [<c01fc31c>] (__driver_attach+0x0/0x98) from [<c01fa794>] (bus_for_each_dev+0x5c/0x90)
> [ 1.994506] r6:c01fc31c r5:c0ca2500 r4:00000000 r3:ef0983bc
> [ 2.000488] [<c01fa738>] (bus_for_each_dev+0x0/0x90) from [<c01fbcfc>] (driver_attach+0x24/0x28)
> [ 2.009735] r6:c0c9a2f8 r5:ef27d500 r4:c0ca2500
> [ 2.014587] [<c01fbcd8>] (driver_attach+0x0/0x28) from [<c01fb838>] (bus_add_driver+0xdc/0x260)
> [ 2.023742] [<c01fb75c>] (bus_add_driver+0x0/0x260) from [<c01fca30>] (driver_register+0x80/0xfc)
> [ 2.033081] r8:c0488074 r7:00000066 r6:c0caa040 r5:00000006 r4:c0ca2500
> [ 2.040161] [<c01fc9b0>] (driver_register+0x0/0xfc) from [<c01fd728>] (__platform_driver_register+0x50/0x64)
> [ 2.050476] r5:00000006 r4:c04975b8
> [ 2.054260] [<c01fd6d8>] (__platform_driver_register+0x0/0x64) from [<c048808c>] (omap2_onenand_driver_init+0x18/0x20)
> [ 2.065490] [<c0488074>] (omap2_onenand_driver_init+0x0/0x20) from [<c0008888>] (do_one_initcall+0xf4/0x150)
> [ 2.075836] [<c0008794>] (do_one_initcall+0x0/0x150) from [<c046db8c>] (kernel_init_freeable+0xf0/0x1b4)
> [ 2.085815] [<c046da9c>] (kernel_init_freeable+0x0/0x1b4) from [<c0348fe0>] (kernel_init+0x10/0xec)
> [ 2.095336] [<c0348fd0>] (kernel_init+0x0/0xec) from [<c000e7f8>] (ret_from_fork+0x14/0x3c)
> [ 2.104125] r4:00000000 r3:00000000
> [ 2.107879] Code: ebffc3ae e2505000 ba00002e e2843042 (e1d320b0)
> [ 2.114318] ---[ end trace b8ee3e3e5e002451 ]---
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen at iki.fi>
> ---
> arch/arm/mach-omap2/gpmc-onenand.c | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/gpmc-onenand.c b/arch/arm/mach-omap2/gpmc-onenand.c
> index 64b5a83..8b6876c 100644
> --- a/arch/arm/mach-omap2/gpmc-onenand.c
> +++ b/arch/arm/mach-omap2/gpmc-onenand.c
> @@ -272,9 +272,19 @@ static int omap2_onenand_setup_async(void __iomem *onenand_base)
> struct gpmc_timings t;
> int ret;
>
> - if (gpmc_onenand_data->of_node)
> + if (gpmc_onenand_data->of_node) {
> gpmc_read_settings_dt(gpmc_onenand_data->of_node,
> &onenand_async);
> + if (onenand_async.sync_read || onenand_async.sync_write) {
> + if (onenand_async.sync_write)
> + gpmc_onenand_data->flags |=
> + ONENAND_SYNC_READWRITE;
> + else
> + gpmc_onenand_data->flags |= ONENAND_SYNC_READ;
> + onenand_async.sync_read = false;
> + onenand_async.sync_write = false;
> + }
> + }
>
> omap2_onenand_set_async_mode(onenand_base);
>
> --
> 1.8.4.rc3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
More information about the linux-arm-kernel
mailing list