[PATCH 03/04] ARM: shmobile: Genmai I2C-over-GPIO support

[Sergei Shtylyov]

Hello.

On 28-11-2013 21:14, Laurent Pinchart wrote:

>>>> +		#address-cells = <1>;
>>>> +		#size-cells = <0>;
>>>> +
>>>> +		eeprom: 24c128 at 50 {
>>>> +			compatible = "at,24c128";

>>> Minor nit: Should be a vendor name, not the name of the driver

>> Moreover, the node should be named generically, like "flash at 50", not
>> "24c128 at 50".

> Or, given that it's an eeprom, "eeprom at 50" ? :-)

    At least ePAPR spec. only has "flash".

WBR, Sergei