[PATCH 2/4] mtd: spi-nor: add a new data structrue spi_nor{}

Marek Vasut marex at denx.de
Wed Nov 27 05:27:09 EST 2013


Dear Huang Shijie,

> 于 2013年11月27日 17:32, Marek Vasut 写道:
> > So this is your own device pointer or ... what kind of device pointer?
> 
> the pointer from spi_device{}

OK, I am 200% positive you need to add comments into the structure about what 
exactly does each member of it mean AND it would be nice if you could rename 
them to have less generic names (like spi_dev instead of dev).

Thanks ! :)

Best regards,
Marek Vasut



More information about the linux-arm-kernel mailing list