[PATCH v2] ARM: remove name from machine_desc for DT platforms

Grant Likely grant.likely at secretlab.ca
Tue Nov 19 08:43:11 EST 2013


On Mon, Nov 18, 2013 at 1:54 PM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> On Fri, Nov 15, 2013 at 02:16:29AM +0900, Grant Likely wrote:
>> On Thu, Nov 14, 2013 at 11:46 PM, Rob Herring <robherring2 at gmail.com> wrote:
>> > If this is a required feature then we should make machine_desc common
>> > (or at least part of it) with the other arches that have copied arm and
>> > then add it to arm64 as well. Then I could do further consolidation of
>> > the FDT machine matching code. Otherwise this is all just pointless
>> > architecture variation that really has nothing to do with the architecture.
>>
>> I think you are missing my point. go ahead, take it out of
>> /proc/cpuinfo. That's not the issue.
>
> You do realise this is a user API issue, right?
>
> http://fossies.org/dox/glibc-2.18/ports_2sysdeps_2unix_2sysv_2linux_2arm_2ioperm_8c_source.html
>
> Right, it only has four strings which it matches against, but this is
> evidence that /proc/cpuinfo is a user API, and the strings therein are
> used by userspace in ways you don't expect.
>
> We can't just go around removing things.

Not everything we end up exporting ends up being an ABI. If nobody
uses it (or complains when we remove it in the obscure cases) then
there is no problem :-)

You're absolutely right here though. I strongly doubt the string
matters for the DT platforms, but you're right that it should not be
changed for the old board support.

g.



More information about the linux-arm-kernel mailing list