[PATCH] ARM: signal: fix armv7-m build issue in sigreturn_codes.S

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Mon Nov 11 04:33:11 EST 2013


Hi Victor,

On Mon, Nov 11, 2013 at 12:10:26AM -0800, Victor Kamensky wrote:
> Here is proposal for armv7-m build failure in sigreturn_codes.S. The 
> armv7-m build issue was discussed in [1].
> 
> Proposed solution is based on conditional compilation. If 
> CONFIG_CPU_THUMBONLY is set instead of arm opcodes nops in thumb mode
> are used. I've tried to wrap conditional compilation as nice as I 
> found possible. Other suggestions/approaches are welcome.
> 
> Fix was tested:
>    linux-next with efm32_defconfig build (along with few other fixes)
>    rmk-next BE/LE arndale build/boot and LTP rt_sigaction0? tests run
Next currently fails for other reasons, too and I'm out of time. I'd say
if it compiles for you it's fine and I will handle eventual fall-outs
later.

> Uwe, is it possible for you to test that the fix runs on efm32. Also
> if the platform can run LTP, you give a spin to LTP rt_sigaction0? 
> tests that would be great. It is known that this tests covers code 
> under change.
No, at least not as easily as enable/install LTP and run it. ptxdist
doesn't offer a working LTP integration unfortunately.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list