[PATCH 0/2] ARM: mvebu: fix DT def. of PCIe units for mv78230 and mv78260

Arnaud Ebalard arno at natisbad.org
Wed Nov 6 16:32:57 EST 2013


Hi Jason,

Jason Cooper <jason at lakedaemon.net> writes:

> On Wed, Nov 06, 2013 at 11:37:24AM -0700, Jason Gunthorpe wrote:
> ...
>> This PCI stuff would be 100% more readable with some macros ..
>> 
>> #define PCI_REG_BDF(bus,device,function) (....)
>> #define PCI_MEM_BAR_BDF(bus,device,function,bar) \
>>    (0x82000000 | PCI_REG_BDF(bus,device,function) + bar*XX) 0)
>> 
>> So that:
>>  reg = <PCI_REG_BDF(0,1,0) 0 0>
>>  assigned-addresses = <PCI_MEM_BAR_BDF(0,1,0,0)  0x40000  0 0x2000>
>
> Do I smell a patch brewing?  :)
>
> Arnaud, would you like to take a crack at it?

My understanding of the topic being in the end limited to what I learnt
from recent discussions, I'll pass on that one but I'll be happy to test
on a mv78230.

Cheers,

a+



More information about the linux-arm-kernel mailing list