[PATCH 1/2] sh-pfc: r8a7779: Don't group USB OVC and PENC pins

Simon Horman horms at verge.net.au
Fri May 31 03:43:26 EDT 2013


On Thu, May 30, 2013 at 11:11:36PM -0700, Olof Johansson wrote:
> On Thu, May 30, 2013 at 10:45 PM, Simon Horman <horms at verge.net.au> wrote:
> > On Thu, May 30, 2013 at 09:43:08PM -0700, Olof Johansson wrote:
> >> Hi,
> >>
> >> On Thu, May 30, 2013 at 5:17 PM, Simon Horman <horms at verge.net.au> wrote:
> >> > On Thu, May 30, 2013 at 10:08:56PM +0200, Linus Walleij wrote:
> >> >> On Thu, May 30, 2013 at 12:28 AM, Simon Horman
> >> >> <horms+renesas at verge.net.au> wrote:
> >> >>
> >> >> > From: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com>
> >> >> >
> >> >> > The USB_OVCn pins are alternate options for USB over-current detection
> >> >> > when using a 3.3V USB interface. As they're not mandatory they can be
> >> >> > used independently of the USB PENC pins. Don't group the USB_OVCn and
> >> >> > PENC pins to avoid conflicts when the USB_OVCn pins are used by another
> >> >> > function.
> >> >> >
> >> >> > Reported-by: Sergei Shtylyov <sergei.shtylyov at cogentembedded.com>
> >> >> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com>
> >> >> > Signed-off-by: Simon Horman <horms+renesas at verge.net.au>
> >> >>
> >> >> OK, Acked-by, do you want me to take this as a fix in the pinctrl
> >> >> tree for v3.10?
> >> >>
> >> >> Just asking because Simon usually takes everything else relating to
> >> >> the SH. ...
> >> >
> >> > This was a pull request from my tree to arm-soc, so thats they way
> >> > I was planning to handle things.
> >> >
> >> > Olof, Arnd,
> >> >
> >> > should I re-spin the pull request to include Linus's ack?
> >>
> >> You can if you want, but for an odd and specific fix like this we'll
> >> all know he's ok with the code going in.
> >
> > In that case my preference is to leave the pull request as is.
> > Could you consider merging it?
> 
> Yes, I will do a pass tomorrow and handle the outstanding merges.
> 
> > As an aside, I do expect to send some more v3.10 fixes for shmobile.
> > There seem to be more than usual.
> 
> A little unfortunate but it's hard to do much about.
> 
> Please be conservative with what you pick up for 3.10 vs 3.11 -- Linus
> has said he really wants to see things slow down.
> 
> And please make our case as easy as possible by making sure it's
> pretty clear from the patch descriptions what kind of bugs they fix
> (and if they are regressions).

Understood. I will be careful to only send the bare essentials for v3.10.



More information about the linux-arm-kernel mailing list