[PATCH 1/5] ARM: socfpga: dts: Add ethernet bindings for SOCFPGA

Dinh Nguyen dinh.linux at gmail.com
Wed May 15 12:44:08 EDT 2013


Hi Pavel,

Thanks for the review...

On 05/15/2013 07:43 AM, Pavel Machek wrote:
> On Tue 2013-05-14 17:52:31, dinguyen at altera.com wrote:
>> From: Dinh Nguyen <dinguyen at altera.com>
>>
>> Add entry for 2nd GMAC controller. Add the correct clocks for the GMAC.
>>
>> Signed-off-by: Dinh Nguyen <dinguyen at altera.com>
>> CC: Arnd Bergmann <arnd at arndb.de>
>> CC: Olof Johansson <olof at lixom.net>
>> CC: Pavel Machek <pavel at denx.de>
>> CC: <linux at arm.linux.org.uk>
> 
> Looks good.
> 
> Reviewed-by: Pavel Machek <pavel at denx.de>
> 
> ...but, this patch is not enough to get ethernet to work with
> 3.10-rc1, right? I hoped that applying 1-3 of the series would get me
> ethernet, but no :-(.

Yes, this fixes a build error for socfpga_defconfig in 3.10-rc1. I'll
send a patch to enable ethernet after these patches are accepted.

Dinh


> 
> Thanks,
> 									Pavel
> 



More information about the linux-arm-kernel mailing list