[PATCH v2] thermal: cpu_cooling: fix stub function

Arnd Bergmann arnd at arndb.de
Wed May 8 08:12:13 EDT 2013


On Thursday 02 May 2013, Eduardo Valentin wrote:
> Rui, Arnd,
> 
> On 02-05-2013 12:29, Arnd Bergmann wrote:
> > The function stub for cpufreq_cooling_get_level introduced
> > in 57df81069 "Thermal: exynos: fix cooling state translation"
> > is not syntactically correct C and needs to be fixed to avoid
> > this error:
> > 
> > In file included from drivers/thermal/db8500_thermal.c:20:0:
> >  include/linux/cpu_cooling.h: In function 'cpufreq_cooling_get_level':
> > include/linux/cpu_cooling.h:57:1:
> >  error: parameter name omitted  unsigned long cpufreq_cooling_get_level(unsigned int, unsigned int)  ^
> >  include/linux/cpu_cooling.h:57:1: error: parameter name omitted
> > 
> > Cc: Eduardo Valentin <eduardo.valentin at ti.com>
> > Cc: Zhang Rui <rui.zhang at intel.com>
> > Cc: Amit Daniel kachhap <amit.daniel at samsung.com>
> > Signed-off-by: Arnd Bergmann <arnd at arndb.de>
> 
> Acked-by: Eduardo Valentin <eduardo.valentin at ti.com>

Rui,

Could you please merge that into your thermal/next tree?  Right now,
linux-next fails to build because of this, and you probably don't
want to send the current version to Linus without fixing it.

	Arnd



More information about the linux-arm-kernel mailing list