[PATCH 4/9] ARM: OMAP4: cpuidle: fix wrong driver initialization

Daniel Lezcano daniel.lezcano at linaro.org
Fri Mar 29 06:45:51 EDT 2013


On 03/29/2013 11:38 AM, Santosh Shilimkar wrote:
> On Friday 29 March 2013 04:01 PM, Daniel Lezcano wrote:
>> The driver is initialized several times. This is wrong and if the
>> return code of the function was checked, it will return -EINVAL.
>>
>> Move this initialization out of the loop.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano at linaro.org>
>> ---
> Fix for this is already and v2 of the patch is here [1]

Ah, ok. Thanks for reviewing the patch.

Can we find a solution to have a single entry point to sumbit patches
for all the cpuidle drivers ?

Otherwise, consolidating them is a pain: a patch for the samsung tree,
another one for the at91 tree, etc ... and wait for all the trees to
sync before continuing to consolidate the code.

Wouldn't be worth to move these drivers under the PM umbrella instead of
the SoC specific code ?

Any idea to simplify the cpuidle consolidation and maintenance ?

Thanks
  -- Daniel


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog




More information about the linux-arm-kernel mailing list