[PATCH v2 04/10] arm: zynq: Load scu baseaddress at run time

[Michal Simek]

2013/3/27 Steffen Trumtrar <s.trumtrar at pengutronix.de>:
> On Wed, Mar 27, 2013 at 11:09:45AM +0100, Michal Simek wrote:
>> 2013/3/27 Arnd Bergmann <arnd at arndb.de>:
>> > On Wednesday 27 March 2013, Michal Simek wrote:
>> >> FYI: I have looked at some code and I saw that Rob is using scu_base_addr
>> >> in highbank. And then pointing to it in cpuidle-calxeda.c.
>> >
>> > Yes, the point is that it works as long as only one person uses that
>> > identifier, so we should either not use it at all, or have a single
>> > global definition shared by all ARM platforms.
>>
>> yep.
>>
>> >> Moving everything to one file is probably impossible.
>> >>
>> >> And in connection to symbols/functions/variables. It means that all
>> >> specific soc functions in mach
>> >> should also use specific prefix for everything.
>> >
>> > That is a good rule, although for static symbols it is not a bug
>> > if they don't have a prefix.
>>
>> ok. Let me check all my patches and Add there zynq_ prefix everywhere.
>>
>
> While you're at, how about getting rid of the xilinx in the names and use
> just zynq_* ?

yep. That's what I am going to do.


> I would also suggest s/xttc/ttc/g in your timer patch. It is up to you,
> but I think the x doesn't make any sense anymore.

Agree. I don't know the historical reason for this.
Also in xilinx git repo there was PSS instead of PS everywhere.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform