[PATCH 05/16] thermal: mvebu: Fix valid check for thermal register

Jason Cooper jason at lakedaemon.net
Thu Mar 21 11:24:00 EDT 2013


On Thu, Mar 21, 2013 at 12:16:10PM -0300, Ezequiel Garcia wrote:
> Hi Jason,
> 
> On Thu, Mar 21, 2013 at 10:35:39AM -0400, Jason Cooper wrote:
> > On Wed, Mar 20, 2013 at 07:36:26PM -0300, Ezequiel Garcia wrote:
> > > The correct value is obtain by first shifting the register by the offset,
> > > later applying the valid mask and finally invert the result.
> > > This check was lacking an extra parenthesis to be strictly correct.
> > > 
> > > Signed-off-by: Ezequiel Garcia <ezequiel.garcia at free-electrons.com>
> > > ---
> > >  drivers/thermal/mvebu_thermal.c |    4 ++--
> > >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > For the next version of this series, could you please put this fix first
> > in the series?  In this state, it can't be applied to v3.9-rcX, nor
> > -stable.
> > 
> 
> Given we're still discussing the aproach of this patchset.
> I think I prefer to send the fixes now, not as part of the
> current series but as independent patches.
> 
> What do you think?

I agree.

thx,

Jason.



More information about the linux-arm-kernel mailing list