[v2 4/4] sata: imx: add ahci sata support on imx platforms

Shawn Guo shawn.guo at linaro.org
Mon Jul 1 10:48:19 EDT 2013


On Mon, Jul 01, 2013 at 04:57:35PM +0530, Girish K S wrote:
> Hello Richard,
> 
> Instead of writing a separate driver for the changes you mentioned in
> the commit message. you can just add those changes to
> the platform data (pdata-> init).

No. The platform init hook is not used to do IP block related setup.
If we're mapping ahci block and setting up ahci registers in platform
code, we are generally not doing the right thing.

Shawn




More information about the linux-arm-kernel mailing list