[PATCH 6/6] ARM: integrator: ensure ap_syscon_base is initialised when !CONFIG_MMU

Will Deacon will.deacon at arm.com
Thu Jan 31 17:34:17 EST 2013


Hi Linus,

On Thu, Jan 31, 2013 at 08:21:04PM +0000, Linus Walleij wrote:
> On Wed, Jan 30, 2013 at 3:27 PM, Will Deacon <will.deacon at arm.com> wrote:
> 
> > When running on Integrator/AP using atags, ap_syscon_base is initialised
> > in ->map_io, which isn't called for !MMU platforms.
> 
> Oh hm. Haha apparently there is one guy with more bizarre hobbies
> than myself, you're making me feel un-geeky... ;-)

Ha! Unfortunately, I only have one core-tile otherwise you could have one to
help you feel less left-out :)

> > Instead, initialise the pointer in ->machine_init, as we do when booting
> > with device-tree.
> 
> I was trying to figure out if there is some case where we need it earlier
> but apparently not so.
> 
> Acked-by: Linus Walleij <linus.walleij at linaro.org>

Cheers!

> Maybe you should send this oneliner directly to the ARM SoC
> people?

[adding Olof and Arnd] Is it worth sending a pull request containing a
single patch, or can this patch just be picked directly?

Cheers,

Will



More information about the linux-arm-kernel mailing list