[PATCH v2] cpufreq: instantiate cpufreq-cpu0 as a platform_driver

Rafael J. Wysocki rjw at sisk.pl
Wed Jan 30 08:40:35 EST 2013


On Wednesday, January 30, 2013 07:10:20 AM AnilKumar, Chimata wrote:
> On Tue, Jan 29, 2013 at 08:23:40, Shawn Guo wrote:
> > As multiplatform build is being adopted by more and more ARM platforms,
> > initcall function should be used very carefully.  For example, when
> > GENERIC_CPUFREQ_CPU0 is built in the kernel, cpu0_cpufreq_driver_init()
> > will be called on all the platforms to initialize cpufreq-cpu0 driver.
> > 
> > To eliminate this undesired the effect, the patch changes cpufreq-cpu0
> > driver to have it instantiated as a platform_driver.  Then it will only
> > run on platforms that create the platform_device "cpufreq-cpu0".
> > 
> > Along with the change, it also changes cpu_dev to be &pdev->dev,
> > so that managed functions can start working, and module build gets
> > supported too.
> > 
> > The existing users of cpufreq-cpu0 driver highbank and am33xx are also
> > updated accordingly to adapt the changes.
> > 
> > Signed-off-by: Shawn Guo <shawn.guo at linaro.org>
> > Cc: Mark Langsdorf <mark.langsdorf at calxeda.com>
> > Cc: AnilKumar Ch <anilkumar at ti.com>
> > Cc: Tony Lindgren <tony at atomide.com>
> > Cc: Rafael J. Wysocki <rafael.j.wysocki at intel.com>
> > ---
> > Changes since v1:
> >  * Migrate cpufreq-cpu0 users in the same patch
> > 
> > Rafael,
> > 
> > The patch is based on Mark's highbank-cpufreq series and Nishanth's
> > "PM / OPP : export symbol consolidation" sereis.
> > 
> > Mark, AnilKumar,
> > 
> > I only compile-tested it on highbank and omap2.  Please give it a test
> > no hardware to make sure cpufreq-cpu0 still works for you.  Thanks.
> 
> Hi Shawn,
> 
> I hope this is based on linux-omap/master, to test the driver I have
> to add some patches on top of this patch, because of recent changes.
> I will provide the test details once I am done.

Shawn, does it mean I need to wait with applying the patch or will OMAP2
work as is?

Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.



More information about the linux-arm-kernel mailing list