[PATCH] serial: pl010/pl011: move clk_enable from console write to setup

Linus Walleij linus.walleij at linaro.org
Tue Jan 29 12:45:10 EST 2013


On Tue, Jan 29, 2013 at 5:05 PM, Liming Wang <walimisdev at gmail.com> wrote:

> There seems no need to call clk_enable in every console writing. And we
> can move clk_enable to setup function to enable the clock only once.
> Also combine the clk_enable and clk_prepare to clk_prepare_enable.
>
> Signed-off-by: Liming Wang <walimisdev at gmail.com>

NAK.

Consider the case where the console outputs nothing or
a string every 30 minutes. Why should we not gate off the
clock between these sporadic prints?

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list