[RFC PATCH 3/6] ARM: kirkwood: nsa310: cleanup includes and unneeded code

Florian Fainelli florian at openwrt.org
Thu Jan 24 08:43:15 EST 2013


On 01/24/2013 06:50 AM, Andrew Lunn wrote:
> On Wed, Jan 23, 2013 at 11:34:21PM +0000, Jason Cooper wrote:
>> Signed-off-by: Jason Cooper <jason at lakedaemon.net>
>> ---
>>   arch/arm/mach-kirkwood/board-nsa310.c | 9 +--------
>>   1 file changed, 1 insertion(+), 8 deletions(-)
>>
>> diff --git a/arch/arm/mach-kirkwood/board-nsa310.c b/arch/arm/mach-kirkwood/board-nsa310.c
>> index 1bd328d..0b99533 100644
>> --- a/arch/arm/mach-kirkwood/board-nsa310.c
>> +++ b/arch/arm/mach-kirkwood/board-nsa310.c
>> @@ -10,11 +10,8 @@
>>
>>   #include <linux/kernel.h>
>>   #include <linux/init.h>
>> -#include <linux/i2c.h>
>> -
>> -#include <asm/mach-types.h>
>> -#include <asm/mach/arch.h>
>>   #include <mach/kirkwood.h>
>> +#include <linux/of.h>
>>   #include "common.h"
>>   #include "mpp.h"
>>
>> @@ -40,11 +37,7 @@ static unsigned int nsa310_mpp_config[] __initdata = {
>>
>>   void __init nsa310_init(void)
>>   {
>> -	u32 dev, rev;
>> -
>>   	kirkwood_mpp_conf(nsa310_mpp_config);
>> -
>> -	kirkwood_pcie_id(&dev, &rev);
>>   }
>>
>>   static int __init nsa310_pci_init(void)
>> --
>> 1.8.1.1
>>
>
> Hi Jason, Tero
>
> This board is rather unusual for a Kirkwood. It has no Ethernet
> interfaces. Is this correct?

It seems like it really has an Gigabit Ethernet interface:
http://www.clubic.com/disque-dur-memoire/nas/article-465814-1-zyxel-nsa-310.html

(in french, but the pictures show a Gigabit Ethernet).
--
Florian



More information about the linux-arm-kernel mailing list