[PATCH] ARM: VIC: use irq_domain_add_simple()

Linus Walleij linus.walleij at linaro.org
Fri Jan 11 15:38:45 EST 2013


On Fri, Jan 11, 2013 at 7:57 PM, Grant Likely <grant.likely at secretlab.ca> wrote:

>> Does the below patch work for you, it does two things:
>>
>> 1) Bump all Versatile IRQs to offset at 32, because it is using
>>   IRQ 0 which is NO_IRQ and illegal anyway so it's anyway
>>   a bug that should be fixed.
>>
>> 2) Make sure we call irq_create_mapping() if the start IRQ is
>>   anyway 0, as in the device tree case, and make sure to
>>   actually pass zero in that case.
>
> In actual fact, only changing the offset to 32 is required to get
> Versatile to boot with DT. That platform doesn't yet use vic_of_init().
> It currently depends on pre-allocated irq_descs.

OK both are already upstream, because there was someone
else verifying they solved the problem.

And the second patch was needed on the Integrator which
does use SPARSE_IRQ + vic_init_of().
Probably the DT-based SPEArs need it too.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list