[RFC v2 05/18] ARM: OMAP2+: AM33XX: CM/PRM: Use __ASSEMBLER__ macros in header files

Bedia, Vaibhav vaibhav.bedia at ti.com
Wed Jan 9 00:31:45 EST 2013


On Tue, Jan 08, 2013 at 20:31:44, Shilimkar, Santosh wrote:
[...]
> > +#endif /* ASSEMBLER */
> > +
> Drop that extra line.

Ok.

> >   #endif
> > diff --git a/arch/arm/mach-omap2/prm33xx.h b/arch/arm/mach-omap2/prm33xx.h
> > index 3f25c56..2f2eaa0 100644
> > --- a/arch/arm/mach-omap2/prm33xx.h
> > +++ b/arch/arm/mach-omap2/prm33xx.h
> > @@ -117,6 +117,7 @@
> >   #define AM33XX_PM_CEFUSE_PWRSTST_OFFSET		0x0004
> >   #define AM33XX_PM_CEFUSE_PWRSTST		AM33XX_PRM_REGADDR(AM33XX_PRM_CEFUSE_MOD, 0x0004)
> >
> > +#ifndef __ASSEMBLER__
> >   extern u32 am33xx_prm_read_reg(s16 inst, u16 idx);
> >   extern void am33xx_prm_write_reg(u32 val, s16 inst, u16 idx);
> >   extern u32 am33xx_prm_rmw_reg_bits(u32 mask, u32 bits, s16 inst, s16 idx);
> > @@ -126,4 +127,6 @@ extern int am33xx_prm_is_hardreset_asserted(u8 shift, s16 inst,
> >   extern int am33xx_prm_assert_hardreset(u8 shift, s16 inst, u16 rstctrl_offs);
> >   extern int am33xx_prm_deassert_hardreset(u8 shift, s16 inst,
> >   		u16 rstctrl_offs, u16 rstst_offs);
> > +#endif /* ASSEMBLER */
> > +
> ditto
> 

Ok.
> Otherwise looks fine.
> Acked-by: Santosh Shilimkar <santosh.shilimkar at ti.com>
> 

Thanks,
Vaibhav



More information about the linux-arm-kernel mailing list