[RFC v2 03/18] memory: emif: Move EMIF related header file to include/linux/

[Bedia, Vaibhav]

On Tue, Jan 08, 2013 at 19:34:41, Shilimkar, Santosh wrote:
[...]
> >
> >   drivers/memory/emif.c   |    2 +-
> >   drivers/memory/emif.h   |  589 -----------------------------------------------
> >   include/linux/ti_emif.h |  589 +++++++++++++++++++++++++++++++++++++++++++++++
> You are just moving the file. So "git mv file1 flie2; and the git 
> format-patch -C"
> on committed patch should just generate few lines of patch.
> 

Ok. Didn't know about this.

> > +/* DDR_PHY_CTRL_1 - EMIF4D5 */
> > +#define DLL_HALF_DELAY_SHIFT_4D5			21
> > +#define DLL_HALF_DELAY_MASK_4D5				(1 << 21)
> > +#define READ_LATENCY_SHIFT_4D5				0
> > +#define READ_LATENCY_MASK_4D5				(0x1f << 0)
> > +
> > +/* DDR_PHY_CTRL_1_SHDW */
> > +#define DDR_PHY_CTRL_1_SHDW_SHIFT			5
> > +#define DDR_PHY_CTRL_1_SHDW_MASK			(0x7ffffff << 5)
> > +#define READ_LATENCY_SHDW_SHIFT				0
> > +#define READ_LATENCY_SHDW_MASK				(0x1f << 0)
> > +
> > +#ifndef __ASSEMBLY__
> > +/*
> > + * Structure containing shadow of important registers in EMIF
> > + * The calculation function fills in this structure to be later used for
> > + * initialisation and DVFS
> > + */
> > +struct emif_regs {
> Are you using above struct. If not we can leave it in same place and
> just move the register defines.
> 

No, the struct is not used. I'll leave it here in the next version.

Regards,
Vaibhav