[PATCH v3 11/12] gpio: pxa: discard irq base in pxa_gpio_chip

Linus Walleij linus.walleij at linaro.org
Thu Feb 21 14:15:27 EST 2013


On Mon, Feb 18, 2013 at 6:12 AM, Haojian Zhuang
<haojian.zhuang at linaro.org> wrote:

> Discard irq_base in struct pxa_gpio_chip. Use irq_domain instead.
>
> Signed-off-by: Haojian Zhuang <haojian.zhuang at linaro.org>
(...)
> +                       irq_base = 0;
> +               chips[i].domain = irq_domain_add_simple(pdev->dev.of_node,
> +                                                       gc->ngpio, irq_base,
> +                                                       &pxa_irq_domain_ops,
> +                                                       &chips[i]);
> +               if (!chips[i].domain)

Aha... so not at the end you fix it up :-)

Acked-by: Linus Walleij <linus.walleij at linaro.org>

Maybe I can ACK all the others too then, if I know it will end up like
this. But I had a few other review comments.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list