[PATCH v2 1/1] drivers: net: davinci_cpdma: acknowledge interrupt properly

David Miller davem at davemloft.net
Fri Feb 15 15:05:06 EST 2013


From: Mugunthan V N <mugunthanvnm at ti.com>
Date: Thu, 14 Feb 2013 23:56:46 +0530

> +enum {
> +	CPDMA_EOI_RX_THRESH = 0,
> +	CPDMA_EOI_RX,
> +	CPDMA_EOI_TX,
> +	CPDMA_EOI_MISC,
> +};

Do not use enumerations for hardware register values, which must be
exact, otherwise you are potentially going to succumb to the vagaries
of C language enumeration value assignment.



More information about the linux-arm-kernel mailing list