[PATCH 07/11] ARM: integrator: fix build with INTEGRATOR_AP off

Linus Walleij linus.walleij at linaro.org
Fri Feb 15 04:13:50 EST 2013


On Thu, Feb 14, 2013 at 2:49 PM, Arnd Bergmann <arnd at arndb.de> wrote:

> The conditional declaration of ap_uart_data is broken
> and causes this build error:
>
> In file included from arch/arm/mach-integrator/core.c:35:0:
> arch/arm/mach-integrator/common.h:6:37: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
>
> Turning the check into an constant-expression if(IS_ENABLED()) statement
> creates more readable code and solves this problem as well.
>
> Cc: Linus Walleij <linus.walleij at linaro.org>
> Cc: Russell King <linux at arm.linux.org.uk>

Brilliant Arnd, thanks for fixing this!

Reviewed-by: Linus Walleij <linus.walleij at linaro.org>

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list