[PATCH] arm64: cmpxchg: update macros to prevent warnings

Catalin Marinas catalin.marinas at arm.com
Fri Dec 20 09:10:02 EST 2013


On Fri, Dec 20, 2013 at 12:42:14PM +0000, Mark Brown wrote:
> From: Mark Hambleton <mahamble at broadcom.com>
> 
> Make sure the value we are going to return is referenced in order to
> avoid warnings from newer GCCs such as:
> 
> arch/arm64/include/asm/cmpxchg.h:162:3: warning: value computed is not used [-Wunused-value]
>   ((__typeof__(*(ptr)))__cmpxchg_mb((ptr),   \
>    ^
> net/netfilter/nf_conntrack_core.c:674:2: note: in expansion of macro ???cmpxchg???
>   cmpxchg(&nf_conntrack_hash_rnd, 0, rand);
> 
> [Modified to use the current underlying implementation as current
> mainline for both cmpxchg() and cmpxchg_local() does -- broonie]
> 
> Signed-off-by: Mark Hambleton <mahamble at broadcom.com>
> Signed-off-by: Mark Brown <broonie at linaro.org>

I merged the previous one (should be in -next as of last night), I guess
it's the same since the patch doesn't have a version number. But I
wonder whether uses of cmpxchg without checking the return value are
sane.

-- 
Catalin



More information about the linux-arm-kernel mailing list