[PATCH v2 01/11] clk: sunxi: register factors clocks behind composite

Emilio López emilio at elopez.com.ar
Wed Dec 18 06:27:48 EST 2013


Hi Mike,

Thanks for the prompt review! It's much appreciated.

El 17/12/13 23:55, Mike Turquette escribió:
> Quoting Emilio López (2013-12-17 16:44:53)
>> This commit reworks factors clock registration to be done behind a
>> composite clock. This allows us to additionally add a gate, mux or
>> divisors, as it will be needed by some future PLLs.
>>
>> Signed-off-by: Emilio López <emilio at elopez.com.ar>
>> Acked-by: Maxime Ripard <maxime.ripard at free-electrons.com>
>> ---
(...)
> Seems like 5 is a magic number? I guess this type of clock always has
> the same number of parents? Might be good to use a preprocessor macro
> here.

Indeed, these clocks always have less than 5 parents. I'll use a macro 
to make it clearer.

Cheers,

Emilio



More information about the linux-arm-kernel mailing list