[PATCH 2/2] mmc: dw_mmc: add dw_mmc-k3 for k3 platform

Arnd Bergmann arnd at arndb.de
Thu Dec 5 20:39:14 EST 2013


On Friday 08 November 2013, Zhangfei Gao wrote:
> Add dw_mmc-k3.c for k3v2, support sd/emmc
> 
> Signed-off-by: Zhangfei Gao <zhangfei.gao at linaro.org>
> Tested-by: Zhigang Wang <brooke.wangzhigang at huawei.com>

We are currently having the exact same discussion problem on the altera
version of dw_mmc: It seems that all this driver does in addition to the
common code is to have a custom way to set up the card clocks.

In both cases, there is a custom piece of IP logic providing this clock
(here it is in the "hisilicon,pctrl" node). IMHO that should be a proper
clock driver so you can use the existing call to clk_set_rate to set
it up and not need a special platform driver at all.

	Arnd



More information about the linux-arm-kernel mailing list