[PATCH] ARM: Clean up setup printks a bit

Russell King - ARM Linux linux at arm.linux.org.uk
Wed Dec 4 18:41:32 EST 2013


On Wed, Dec 04, 2013 at 03:30:26PM -0800, Olof Johansson wrote:
> Clean up the setup ARM printks a bit. Add printk level to a few
> that were missing (CPU: <...> ones, in particular), and switch from
> printk(KERN_* ..) to pr_*().
> 
> Finally, un-wrap some long lines since it makes it harder to grep the
> sources from where an error came from and tweak some cases of indentation.

All good stuff but you missed one :)

> @@ -564,7 +564,7 @@ static void __init setup_processor(void)
>  	 */
>  	list = lookup_processor_type(read_cpuid_id());
>  	if (!list) {
> -		printk("CPU configuration botched (ID %08x), unable "
> +		pr_err("CPU configuration botched (ID %08x), unable "
>  		       "to continue.\n", read_cpuid_id());
>  		while (1);
>  	}



More information about the linux-arm-kernel mailing list