Build warning in drivers/dma/mmp_tdma.c

[Zhangfei Gao]

Thanks Qiao for confirmation

On Mon, Dec 2, 2013 at 3:34 PM, Qiao Zhou <zhouqiao at marvell.com> wrote:
> On 12/02/2013 02:42 PM, Zhangfei Gao wrote:
>>
>> Thanks Dan
>>
>> On Fri, Nov 29, 2013 at 6:58 AM, Dan Williams <dan.j.williams at intel.com>
>> wrote:
>>
>>> I'm also carrying patch to add a missing dependency:
>>>
>>> commit 1a4ee91dacedde3e82d8ce6eeace7f16884474f9
>>> Author: Dan Williams <dan.j.williams at intel.com>
>>> Date:   Thu Nov 28 12:27:38 2013 -0800
>>>
>>>      dma: mmp_dma depends on CPU_MMP2
>>>
>>>      It calls sram_get_gpool() which is only defined if CONFIG_CPU_MMP2=y
>>>
>>>      Signed-off-by: Dan Williams <dan.j.williams at intel.com>
>>>
>>> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
>>> index 446687cc2334..dad83634cb65 100644
>>> --- a/drivers/dma/Kconfig
>>> +++ b/drivers/dma/Kconfig
>>> @@ -287,7 +287,7 @@ config DMA_SA11X0
>>>
>>>   config MMP_TDMA
>>>          bool "MMP Two-Channel DMA support"
>>> -       depends on ARCH_MMP
>>> +       depends on ARCH_MMP && CPU_MMP2
>>
>>
>> Hi, Qiao
>>
>> Do you have comments?
>> Does this work on PXA910?
>
> MMP_TDMA should not depend on CPU_MMP2. PXA910, and other chip set also use
> mmp_tdma.
>
>>
>> Does sram also use on pxa910?
>> arch/arm/mach-mmp/Makefile
>> obj-$(CONFIG_CPU_MMP2)          += mmp2.o sram.o
>
> yes, PXA910 also uses sram.

Then we may need clarify the dependence about sram.o to solve Dan's question?

Thanks