[PATCH v5 5/8] usb: musb: omap2430: Don't use omap_get_control_dev()

Sergei Shtylyov sergei.shtylyov at cogentembedded.com
Tue Aug 20 13:57:24 EDT 2013


Hello.

On 08/20/2013 06:56 PM, Roger Quadros wrote:

> omap_get_control_dev() is being deprecated as it doesn't support
> multiple instances. As control device is present only from OMAP4
> onwards which supports DT only, we use phandles to get the
> reference to the control device.

> Also get rid of "ti,has-mailbox" property as it is redundant and
> we can determine that from whether "ctrl-module" property is present
> or not. Get rid of has_mailbox from musb_hdrc_platform_data as well.

> Signed-off-by: Roger Quadros <rogerq at ti.com>
[...]

> diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
> index ebb46ec..516795b 100644
> --- a/drivers/usb/musb/omap2430.c
> +++ b/drivers/usb/musb/omap2430.c
[...]
> @@ -509,8 +510,12 @@ static int omap2430_probe(struct platform_device *pdev)
>   	glue->dev			= &pdev->dev;
>   	glue->musb			= musb;
>   	glue->status			= OMAP_MUSB_UNKNOWN;
> +	glue->control_otghs = ERR_PTR(-ENODEV);

    Could you please align = with the others above?

WBR, Sergei




More information about the linux-arm-kernel mailing list